[PATCH] D32530: [SVE][IR] Scalable Vector IR Type

David Greene via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 20 11:11:09 PDT 2019


greened added inline comments.


================
Comment at: docs/LangRef.rst:678
 
+:ref:`Scalable vectors <t_vector>` cannot be global variables because their
+size is unknown at compile time.
----------------
Add a similar comment about scalable vector types in aggregates?


================
Comment at: include/llvm/Support/ScalableSize.h:6
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
----------------
Needs updated license.


================
Comment at: include/llvm/Support/ScalableSize.h:17
+
+#ifndef LLVM_SCALABLESIZE_H
+#define LLVM_SCALABLESIZE_H
----------------
Should be `LLVM_SUPPORT_SCALABLESIZE_H`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D32530/new/

https://reviews.llvm.org/D32530





More information about the llvm-commits mailing list