[llvm] r356583 - [Remarks] Fix mismatched delete due to missing virtual destructor

[Jordan Rupprecht via llvm-commits]

Author: rupprecht
Date: Wed Mar 20 10:44:24 2019
New Revision: 356583

URL: http://llvm.org/viewvc/llvm-project?rev=356583&view=rev
Log:
[Remarks] Fix mismatched delete due to missing virtual destructor

This fixes an asan failure introduced in r356519.

Modified:
    llvm/trunk/lib/Remarks/RemarkParserImpl.h

Modified: llvm/trunk/lib/Remarks/RemarkParserImpl.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Remarks/RemarkParserImpl.h?rev=356583&r1=356582&r2=356583&view=diff
==============================================================================
--- llvm/trunk/lib/Remarks/RemarkParserImpl.h (original)
+++ llvm/trunk/lib/Remarks/RemarkParserImpl.h Wed Mar 20 10:44:24 2019
@@ -19,6 +19,10 @@ namespace remarks {
 struct ParserImpl {
   enum class Kind { YAML };
 
+  explicit ParserImpl(Kind TheParserKind) : ParserKind(TheParserKind) {}
+  // Virtual destructor prevents mismatched deletes
+  virtual ~ParserImpl() {}
+
   // The parser kind. This is used as a tag to safely cast between
   // implementations.
   Kind ParserKind;