[PATCH] D59564: [LICM & MemorySSA] Don't sink/hoist stores in the presence of ordered loads.
Alina Sbirlea via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 20 10:20:47 PDT 2019
asbirlea marked an inline comment as done.
asbirlea added inline comments.
================
Comment at: lib/Transforms/Scalar/LICM.cpp:1196
+ // walking a list that long.
+ if (NoOfMemAccTooLarge)
+ return false;
----------------
george.burgess.iv wrote:
> Is this bit relevant to PR41140? If not, please commit separately.
This was in the previous code, and it's needed. I just refactored the code a bit, and moved this check before calling getClobbering to get an early exit.
Also inverted the OptCap check in the latest update to decrease indent.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59564/new/
https://reviews.llvm.org/D59564
More information about the llvm-commits
mailing list