[PATCH] D59571: [Remarks] Emit a section containing remark diagnostics metadata

[Francis Visoiu Mistrih via Phabricator via llvm-commits]

thegameg marked an inline comment as done.
thegameg added inline comments.


================
Comment at: llvm/test/CodeGen/X86/remarks-section.ll:2
+; RUN: llc < %s -mtriple=x86_64-linux -remarks-section -pass-remarks-output=/dev/null | FileCheck %s
+; RUN: llc < %s -mtriple=x86_64-darwin -remarks-section -pass-remarks-output=/dev/null  | FileCheck --check-prefix=CHECK-DARWIN %s
+
----------------
ormris wrote:
> Quick drive-by nit: I noticed that this uses "/dev/null".  This will cause failures on the Windows bots, since Windows doesn't provide that file.
Thanks for the heads-up. What would be the solution to this? Is this any different from all the other tests using `-o /dev/null` or `> /dev/null`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59571/new/

https://reviews.llvm.org/D59571