[PATCH] D57028: [AMDGPU] Added MsgPack format PAL metadata

[Scott Linder via Phabricator via llvm-commits]

scott.linder accepted this revision.
scott.linder added a comment.
This revision is now accepted and ready to land.

LGTM, thanks! One small change to a comment.



================
Comment at: lib/Target/AMDGPU/Utils/AMDGPUPALMetadata.h:95
+  // ELF::NT_AMD_AMDGPU_PAL_METADATA (legacy key=val format), or
+  // ELF::NT_AMD_AMDGPU_PAL_METADATA_MSGPACK or ELF::NT_AMDGPU_METADATA
+  // (MsgPack format).
----------------
Can we drop `ELF::NT_AMD_AMDGPU_PAL_METADATA_MSGPACK` here?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57028/new/

https://reviews.llvm.org/D57028