[PATCH] D59025: Add --add-ghashes to llvm-objcopy to append a .debug$H to coff objects

[Leonardo Santagada via Phabricator via llvm-commits]

santagada added a comment.

I can, but looking at the code for PDBLinker::mergeInPrecompHeaderObj and the code that calls it, seems like lld is adding the precompiled header multiple times on the output pdb, there is no checks to make sure it only emits the data once.

Also on the --add-ghashes case seems like I would want to find the file in L_precomp, load it but never save the hashes to the pch types to the obj that reference them.

For a final question, does clang generates a .debug$H to precompiled headers? Because if so I probably want to support adding .debug$H to pch files as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59025/new/

https://reviews.llvm.org/D59025