[PATCH] D59554: gn build: Add build files for some clang-tools-extra

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

Thanks!



================
Comment at: llvm/utils/gn/secondary/clang-tools-extra/clang-move/BUILD.gn:11
+    "//clang/lib/Frontend",
+    "//clang/lib/Lex",
+    "//clang/lib/Tooling",
----------------
mbonadei wrote:
> Do we also need "//clang/lib/Serialization" here (https://github.com/llvm/llvm-project/blob/master/clang-tools-extra/clang-move/CMakeLists.txt#L17)?
Good catch, done.

In practice it doesn't matter because the tool/ has the dep, but all targets currently try to match the cmake deps (which has them for component builds I think), so I agree this should be here :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59554/new/

https://reviews.llvm.org/D59554