[PATCH] D59416: [Legacy][TimePasses] allow -time-passes reporting into a custom stream

[Fedor Sergeev via Phabricator via llvm-commits]

fedor.sergeev added inline comments.


================
Comment at: include/llvm/IR/PassTimingInfo.h:32
 /// If -time-passes has been specified, report the timings immediately and then
-/// reset the timers to zero.
-void reportAndResetTimings();
+/// reset the timers to zero. By default it uses info-output-file stream.
+void reportAndResetTimings(raw_ostream *OutStream = nullptr);
----------------
fedor.sergeev wrote:
> philip.pfaffe wrote:
> > Sorry, this second nit got lost: Is it clear from context what `info-output-file` is? Otherwise reference `CreateInfoOutputFile()` instead.
> Well, both of these would require a search through sources if you do not know what it is.
> info-output-file is a command-line level control, CreateInfoOutputFile is an API control.
> I really do not have any preferences here.
Will it be more clear if I say "By default it uses file stream specified by -info-output-file" ?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59416/new/

https://reviews.llvm.org/D59416