[PATCH] D59496: [llvm-objcopy] - Fix a st_name of the first symbol table entry.

[George Rimar via llvm-commits]

For the record, the following part of my previous message was NOT true:
(I edited the answer in phab, but can't edit the mails it sent :).

"Also, I observe that LLD's string tables produced do not start with a zero byte. It uses
`StringTableBuilder::RAW` type of builders for threaded building intentionally though.
Seems we just do not conform spec a bit there (perhaps we need to add a zero byte manually on a linker side)."

In fact, LLD's string table section does not use StringTableBuilder at all. We build a string table by ourselves:
https://github.com/llvm-mirror/lld/blob/master/ELF/SyntheticSections.cpp#L1163
I just was confused with mergeable sections optimizations, for which we use it.

Best regards,
George | Developer | Access Softek, Inc