[PATCH] D59109: Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2]

Wed Mar 20 03:51:33 PDT 2019

phosek added a comment.

This broke our builders, the error is the following:

  FAIL: Clang :: Driver/compiler-rt-unwind.c (4674 of 14362)
  ******************** TEST 'Clang :: Driver/compiler-rt-unwind.c' FAILED ********************
  Script:
  --
  : 'RUN: at line 4';   /b/s/w/ir/k/recipe_cleanup/clangcmtTrW/llvm_build_dir/bin/clang -no-canonical-prefixes /b/s/w/ir/k/llvm-project/clang/test/Driver/compiler-rt-unwind.c -### -o /b/s/w/ir/k/recipe_cleanup/clangcmtTrW/llvm_build_dir/tools/clang/test/Driver/Output/compiler-rt-unwind.c.tmp.o 2>&1      --target=x86_64-unknown-linux      --gcc-toolchain=""    | /b/s/w/ir/k/recipe_cleanup/clangcmtTrW/llvm_build_dir/bin/FileCheck --check-prefix=RTLIB-EMPTY /b/s/w/ir/k/llvm-project/clang/test/Driver/compiler-rt-unwind.c
  : 'RUN: at line 11';   /b/s/w/ir/k/recipe_cleanup/clangcmtTrW/llvm_build_dir/bin/clang -no-canonical-prefixes /b/s/w/ir/k/llvm-project/clang/test/Driver/compiler-rt-unwind.c -### -o /b/s/w/ir/k/recipe_cleanup/clangcmtTrW/llvm_build_dir/tools/clang/test/Driver/Output/compiler-rt-unwind.c.tmp.o 2>&1      --target=x86_64-unknown-linux -rtlib=libgcc      --gcc-toolchain=""    | /b/s/w/ir/k/recipe_cleanup/clangcmtTrW/llvm_build_dir/bin/FileCheck --check-prefix=RTLIB-GCC /b/s/w/ir/k/llvm-project/clang/test/Driver/compiler-rt-unwind.c
  : 'RUN: at line 18';   /b/s/w/ir/k/recipe_cleanup/clangcmtTrW/llvm_build_dir/bin/clang -no-canonical-prefixes /b/s/w/ir/k/llvm-project/clang/test/Driver/compiler-rt-unwind.c -### -o /b/s/w/ir/k/recipe_cleanup/clangcmtTrW/llvm_build_dir/tools/clang/test/Driver/Output/compiler-rt-unwind.c.tmp.o 2>&1      --target=x86_64-unknown-linux -rtlib=libgcc --unwindlib=libunwind      --gcc-toolchain=""    | /b/s/w/ir/k/recipe_cleanup/clangcmtTrW/llvm_build_dir/bin/FileCheck --check-prefix=RTLIB-GCC-UNWINDLIB-COMPILER-RT /b/s/w/ir/k/llvm-project/clang/test/Driver/compiler-rt-unwind.c
  : 'RUN: at line 25';   /b/s/w/ir/k/recipe_cleanup/clangcmtTrW/llvm_build_dir/bin/clang -no-canonical-prefixes /b/s/w/ir/k/llvm-project/clang/test/Driver/compiler-rt-unwind.c -### -o /b/s/w/ir/k/recipe_cleanup/clangcmtTrW/llvm_build_dir/tools/clang/test/Driver/Output/compiler-rt-unwind.c.tmp.o 2>&1        --target=x86_64-unknown-linux -rtlib=compiler-rt      --gcc-toolchain=""    | /b/s/w/ir/k/recipe_cleanup/clangcmtTrW/llvm_build_dir/bin/FileCheck --check-prefix=RTLIB-COMPILER-RT /b/s/w/ir/k/llvm-project/clang/test/Driver/compiler-rt-unwind.c
  : 'RUN: at line 31';   /b/s/w/ir/k/recipe_cleanup/clangcmtTrW/llvm_build_dir/bin/clang -no-canonical-prefixes /b/s/w/ir/k/llvm-project/clang/test/Driver/compiler-rt-unwind.c -### -o /b/s/w/ir/k/recipe_cleanup/clangcmtTrW/llvm_build_dir/tools/clang/test/Driver/Output/compiler-rt-unwind.c.tmp.o 2>&1        --target=x86_64-unknown-linux -rtlib=compiler-rt --unwindlib=libgcc      --gcc-toolchain=""    | /b/s/w/ir/k/recipe_cleanup/clangcmtTrW/llvm_build_dir/bin/FileCheck --check-prefix=RTLIB-COMPILER-RT-UNWINDLIB-GCC /b/s/w/ir/k/llvm-project/clang/test/Driver/compiler-rt-unwind.c
  : 'RUN: at line 38';   /b/s/w/ir/k/recipe_cleanup/clangcmtTrW/llvm_build_dir/bin/clang -no-canonical-prefixes /b/s/w/ir/k/llvm-project/clang/test/Driver/compiler-rt-unwind.c -### -o /b/s/w/ir/k/recipe_cleanup/clangcmtTrW/llvm_build_dir/tools/clang/test/Driver/Output/compiler-rt-unwind.c.tmp.o 2>&1                   --target=x86_64-unknown-linux -rtlib=compiler-rt --unwindlib=libgcc      -static --gcc-toolchain=""    | /b/s/w/ir/k/recipe_cleanup/clangcmtTrW/llvm_build_dir/bin/FileCheck --check-prefix=RTLIB-COMPILER-RT-UNWINDLIB-GCC-STATIC /b/s/w/ir/k/llvm-project/clang/test/Driver/compiler-rt-unwind.c
  : 'RUN: at line 45';   not /b/s/w/ir/k/recipe_cleanup/clangcmtTrW/llvm_build_dir/bin/clang -no-canonical-prefixes /b/s/w/ir/k/llvm-project/clang/test/Driver/compiler-rt-unwind.c -o /b/s/w/ir/k/recipe_cleanup/clangcmtTrW/llvm_build_dir/tools/clang/test/Driver/Output/compiler-rt-unwind.c.tmp.o 2> /b/s/w/ir/k/recipe_cleanup/clangcmtTrW/llvm_build_dir/tools/clang/test/Driver/Output/compiler-rt-unwind.c.tmp.err                   --target=x86_64-unknown-linux -rtlib=libgcc --unwindlib=libunwind      --gcc-toolchain=""  /b/s/w/ir/k/recipe_cleanup/clangcmtTrW/llvm_build_dir/bin/FileCheck --input-file=/b/s/w/ir/k/recipe_cleanup/clangcmtTrW/llvm_build_dir/tools/clang/test/Driver/Output/compiler-rt-unwind.c.tmp.err --check-prefix=RTLIB-GCC-UNWINDLIB-COMPILER_RT /b/s/w/ir/k/llvm-project/clang/test/Driver/compiler-rt-unwind.c
  --
  Exit Code: 1

  Command Output (stderr):
  --
  /b/s/w/ir/k/llvm-project/clang/test/Driver/compiler-rt-unwind.c:8:17: error: RTLIB-EMPTY: expected string not found in input
  // RTLIB-EMPTY: "{{.*}}lgcc"
                  ^
  <stdin>:1:1: note: scanning from here
  Fuchsia clang version 9.0.0 (https://fuchsia.googlesource.com/a/third_party/llvm-project ba92e9bb1187a2c43ab727fb9685b65898a87a9d) (based on LLVM 9.0.0svn)
  ^
  <stdin>:5:979: note: possible intended match here
   "/b/s/w/ir/k/recipe_cleanup/clangcmtTrW/llvm_build_dir/bin/clang" "-cc1" "-triple" "x86_64-unknown-linux" "-emit-obj" "-mrelax-all" "--mrelax-relocations" "-disable-free" "-main-file-name" "compiler-rt-unwind.c" "-mrelocation-model" "static" "-mthread-model" "posix" "-mdisable-fp-elim" "-fmath-errno" "-masm-verbose" "-mconstructor-aliases" "-munwind-tables" "-fuse-init-array" "-target-cpu" "x86-64" "-dwarf-column-info" "-debugger-tuning=gdb" "-resource-dir" "/b/s/w/ir/k/recipe_cleanup/clangcmtTrW/llvm_build_dir/lib/clang/9.0.0" "-internal-isystem" "/usr/local/include" "-internal-isystem" "/b/s/w/ir/k/recipe_cleanup/clangcmtTrW/llvm_build_dir/lib/clang/9.0.0/include" "-internal-externc-isystem" "/usr/include/x86_64-linux-gnu" "-internal-externc-isystem" "/include" "-internal-externc-isystem" "/usr/include" "-fdebug-compilation-dir" "/b/s/w/ir/k/recipe_cleanup/clangcmtTrW/llvm_build_dir/tools/clang/test/Driver" "-ferror-limit" "19" "-fmessage-length" "0" "-fobjc-runtime=gcc" "-fdiagnostics-show-option" "-o" "/b/s/w/ir/tmp/t/lit_tmp_A2OKVE/compiler-rt-unwind-347fd6.o" "-x" "c" "/b/s/w/ir/k/llvm-project/clang/test/Driver/compiler-rt-unwind.c" "-faddrsig"
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    ^

  --

The full log is here: https://luci-milo.appspot.com/p/fuchsia/builders/ci/clang-x64-linux/b8918524447769519952

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59109/new/

https://reviews.llvm.org/D59109