[PATCH] D59577: [SelectionDAG] Add scalarization of ABS node.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 20 01:12:04 PDT 2019


lebedev.ri added a comment.

In D59577#1436013 <https://reviews.llvm.org/D59577#1436013>, @ikulagin wrote:

> In D59577#1435885 <https://reviews.llvm.org/D59577#1435885>, @lebedev.ri wrote:
>
> > Needs vector tests, to show that the issue is fixed.
>
>
> Ok! What's the best way for test, unittest only for scalarization of vector ABS node or system test for code generation for every architecture?




  $ find -iname *iabs*
  ./AArch64/iabs.ll
  ./ARM/iabs.ll
  ./PowerPC/iabs.ll
  ./Thumb/iabs.ll
  ./X86/viabs.ll
  ./X86/iabs.ll

Only the X86 has vector test coverage here.
At least copy `./X86/viabs.ll` to those other arches.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59577/new/

https://reviews.llvm.org/D59577





More information about the llvm-commits mailing list