[PATCH] D59500: [ConstantFolding] Fix GetConstantFoldFPValue to avoid cast overflow.

Sanjoy Das via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 20 00:20:05 PDT 2019


sanjoy added inline comments.


================
Comment at: test/Transforms/ConstProp/calls.ll:196
 
+define float @test_intrinsic_pow_f32_overflow() nounwind uwtable ssp {
+entry:
----------------
lebedev.ri wrote:
> Please add a comment as to what this testing
Fwiw I think the `f32_overflow` suffix makes it clear what it is testing and is consistent with the rest of the file.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59500/new/

https://reviews.llvm.org/D59500





More information about the llvm-commits mailing list