[PATCH] D59552: [Linker] Fix crash handling appending linkage

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: lib/Linker/IRMover.cpp:1067
+    Old->replaceAllUsesWith(New);
+    Old->eraseFromParent();
+  }
----------------
rafauler wrote:
> efriedma wrote:
> > ValueMap and AliasValueMap use raw pointers for keys.  Do we need to update them if one of those pointers is deleted?
> This is handled in Value's destructor
I don't follow; how could ~Value() possibly find the key of a ValueMap?  (The values are ValueHandles, but that's separate.)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59552/new/

https://reviews.llvm.org/D59552