[PATCH] D59525: Speed up certain locale functions on Windows
Marshall Clow via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 19 15:10:04 PDT 2019
mclow.lists added a comment.
In D59525#1435566 <https://reviews.llvm.org/D59525#1435566>, @smeenai wrote:
> I'm happy to not accept diffs in libc++ directly anymore and instead comment something like "LGTM, but wait for one of @mclow.lists, @EricWF, or @ldionne to review as well", but that seems like a pretty heavy handed policy for changes like this. I'm also curious if you have any specific issues with this diff, or if it's just a general principle.
It's definitely a general principle, not a comment on this diff.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59525/new/
https://reviews.llvm.org/D59525
More information about the llvm-commits
mailing list