[llvm] r356516 - Revert r356511 "[TailCallElim] Add tailcall elimination pass to LTO pipelines"

[Robert Lougher via llvm-commits]

Author: rlougher
Date: Tue Mar 19 13:54:20 2019
New Revision: 356516

URL: http://llvm.org/viewvc/llvm-project?rev=356516&view=rev
Log:
Revert r356511 "[TailCallElim] Add tailcall elimination pass to LTO pipelines"

Due to buildbot failures (LLD tests).


Removed:
    llvm/trunk/test/LTO/X86/tailcallelim.ll
Modified:
    llvm/trunk/lib/Passes/PassBuilder.cpp
    llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp
    llvm/trunk/test/Other/new-pm-lto-defaults.ll

Modified: llvm/trunk/lib/Passes/PassBuilder.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Passes/PassBuilder.cpp?rev=356516&r1=356515&r2=356516&view=diff
==============================================================================
--- llvm/trunk/lib/Passes/PassBuilder.cpp (original)
+++ llvm/trunk/lib/Passes/PassBuilder.cpp Tue Mar 19 13:54:20 2019
@@ -1185,10 +1185,6 @@ PassBuilder::buildLTODefaultPipeline(Opt
   // Break up allocas
   FPM.addPass(SROA());
 
-  // LTO provides additional opportunities for tailcall elimination due to
-  // link-time inlining, and visibility of nocapture attribute.
-  FPM.addPass(TailCallElimPass());
-
   // Run a few AA driver optimizations here and now to cleanup the code.
   MPM.addPass(createModuleToFunctionPassAdaptor(std::move(FPM)));
 

Modified: llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp?rev=356516&r1=356515&r2=356516&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp (original)
+++ llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp Tue Mar 19 13:54:20 2019
@@ -896,10 +896,6 @@ void PassManagerBuilder::addLTOOptimizat
   // Break up allocas
   PM.add(createSROAPass());
 
-  // LTO provides additional opportunities for tailcall elimination due to
-  // link-time inlining, and visibility of nocapture attribute.
-  PM.add(createTailCallEliminationPass());
-
   // Run a few AA driven optimizations here and now, to cleanup the code.
   PM.add(createPostOrderFunctionAttrsLegacyPass()); // Add nocapture.
   PM.add(createGlobalsAAWrapperPass()); // IP alias analysis.

Removed: llvm/trunk/test/LTO/X86/tailcallelim.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/LTO/X86/tailcallelim.ll?rev=356515&view=auto
==============================================================================
--- llvm/trunk/test/LTO/X86/tailcallelim.ll (original)
+++ llvm/trunk/test/LTO/X86/tailcallelim.ll (removed)
@@ -1,22 +0,0 @@
-; Check that the LTO pipelines add the Tail Call Elimination pass.
-
-; RUN: llvm-as < %s > %t1
-; RUN: llvm-lto -o %t2 %t1 --exported-symbol=foo -save-merged-module
-; RUN: llvm-dis < %t2.merged.bc | FileCheck %s
-
-; RUN: llvm-lto2 run -r %t1,foo,plx -r %t1,bar,plx -o %t3 %t1 -save-temps
-; RUN: llvm-dis < %t3.0.4.opt.bc | FileCheck %s
-
-; RUN: llvm-lto2 run -r %t1,foo,plx -r %t1,bar,plx -o %t4 %t1 -save-temps -use-new-pm
-; RUN: llvm-dis < %t4.0.4.opt.bc | FileCheck %s
-
-target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
-target triple = "x86_64-unknown-linux-gnu"
-
-define void @foo() {
-; CHECK: tail call void @bar()
-  call void @bar()
-  ret void
-}
-
-declare void @bar()

Modified: llvm/trunk/test/Other/new-pm-lto-defaults.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Other/new-pm-lto-defaults.ll?rev=356516&r1=356515&r2=356516&view=diff
==============================================================================
--- llvm/trunk/test/Other/new-pm-lto-defaults.ll (original)
+++ llvm/trunk/test/Other/new-pm-lto-defaults.ll Tue Mar 19 13:54:20 2019
@@ -81,7 +81,6 @@
 ; CHECK-O2-NEXT: Running pass: JumpThreadingPass
 ; CHECK-O2-NEXT: Running analysis: LazyValueAnalysis
 ; CHECK-O2-NEXT: Running pass: SROA on foo
-; CHECK-O2-NEXT: Running pass: TailCallElimPass on foo
 ; CHECK-O2-NEXT: Finished llvm::Function pass manager run.
 ; CHECK-O2-NEXT: Running pass: ModuleToPostOrderCGSCCPassAdaptor<{{.*}}PostOrderFunctionAttrsPass>
 ; CHECK-O2-NEXT: Running pass: ModuleToFunctionPassAdaptor<{{.*}}PassManager{{.*}}>