[PATCH] D58426: llvm-objcopy: Change sectionWithinSegment() to use virtual addresses instead of file offsets.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added a comment.

It seems quite easy to handle TLS. See the change that I just uploaded. Similar code would be necessary to correctly extract partitions if for example the first partition had a .tbss whose address space extended into the second partition.

It seems that a number of tests that were added in D59293 <https://reviews.llvm.org/D59293> now fail with this change. I haven't formed an opinion yet on that change, although I suppose that if we wanted to preserve the behaviour introduced in D59293 <https://reviews.llvm.org/D59293> we might consider allocating non-NOBITS sections to segments on the basis of offset/filesz, and NOBITS sections on the basis of vaddr/memsz.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58426/new/

https://reviews.llvm.org/D58426