[PATCH] D59471: [InstCombine] Fold add nuw + uadd.with.overflow

Dan Robertson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 19 12:19:23 PDT 2019


dlrobertson added a comment.

In D59471#1435184 <https://reviews.llvm.org/D59471#1435184>, @spatel wrote:

> Logic looks fine, so I won't hold it up, but seems better to not duplicate code for sibling transforms?


Your change looks much better. I wanted to do something like this initially, but I couldn't figure it out. I was missing `getIntrinsicId`. I'll update this shortly.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59471/new/

https://reviews.llvm.org/D59471





More information about the llvm-commits mailing list