[PATCH] D58426: llvm-objcopy: Change sectionWithinSegment() to use virtual addresses instead of file offsets.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 19 12:07:19 PDT 2019


pcc added a comment.

In D58426#1435243 <https://reviews.llvm.org/D58426#1435243>, @jakehehrlich wrote:

> I mean in the handler for the option you can re-traverse the program headers for each section and handle your check.


I don't understand why you think it would be better to have two code paths, one that allocates sections to segments incorrectly and another that allocates them correctly, rather than just having one code path that allocates them correctly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58426/new/

https://reviews.llvm.org/D58426





More information about the llvm-commits mailing list