[PATCH] D59551: [scudo][standalone] Add error reports

[Matt Morehouse via Phabricator via llvm-commits]

morehouse added inline comments.


================
Comment at: lib/scudo/standalone/report.cc:62
+
+// The checksum of a chunk header is invalid. This could be cause by an
+// {over,under}write of the header, a pointer than is not an actual chunk.
----------------
s/cause/caused


================
Comment at: lib/scudo/standalone/report.cc:63
+// The checksum of a chunk header is invalid. This could be cause by an
+// {over,under}write of the header, a pointer than is not an actual chunk.
+void NORETURN reportHeaderCorruption(void *Ptr) {
----------------
s/a pointer than/or a pointer that


================
Comment at: lib/scudo/standalone/report.cc:79
+// The allocator was compiled with parameters that invalidates some of the
+// requirements needed with regard to fields size.
+void NORETURN reportSanityCheckError(const char *Field) {
----------------
I don't understand what this means exactly.

Maybe you mean something like:  "The allocator was compiled with parameters that conflict with field size requirements."


================
Comment at: lib/scudo/standalone/tests/report_test.cc:31
+                   scudo::AllocatorAction::Reallocating, P, 0, 1),
+               "Scudo ERROR.*reallocating.*42424242");
+  EXPECT_DEATH(scudo::reportDeleteSizeMismatch(P, 123, 456),
----------------
Test for `AllocatorAction::Sizing`?


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59551/new/

https://reviews.llvm.org/D59551