[PATCH] D59419: [XCOFF] Add functionality for parsing AIX XCOFF object files header .

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 19 11:12:21 PDT 2019


sfertile added a comment.

In D59419#1435075 <https://reviews.llvm.org/D59419#1435075>, @rnk wrote:

> My main question would be, how is this going to fit into MC and the rest of LLVM? We support 4(?) object file formats there now (ELF, COFF (pretty much assumes Windows), wasm, and MachO), and MC is not designed to be very extensible. Will Triple::isOSBinFormatCOFF return true for XCOFF, or will it be distinct?


Our intention is for XCOFF to be a distinct object file format. We had a look at the Windows COFF format and it does share some similarities with XCOFF, but overall I think they are too different to try to reconcile into a single COFF object file format. Jason already landed a patch for adding Aix and XCOFF to the triple (here) <https://reviews.llvm.org/rGa03ae73c2932c1795830bfbf6e6b8e87baf8aa3a> and we treat XCOFF as a distinct object format there as well.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59419/new/

https://reviews.llvm.org/D59419





More information about the llvm-commits mailing list