[PATCH] D59156: [DAGCombiner] Use getTokenFactor in a few more cases.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 19 10:24:58 PDT 2019


fhahn added a comment.

In D59156#1429460 <https://reviews.llvm.org/D59156#1429460>, @RKSimon wrote:

> TBH I didn't expect that tests would be easy, but I don't think that should be a stopper to this patch (and code coverage indicates that all these cases are active).


I've got a simple python script to generate a test case, but it takes multiple minutes, because DAGCombine is really slow with lots of stores (which is another thing I am looking into). For now, I think the patch has to go in without test case :(


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59156/new/

https://reviews.llvm.org/D59156





More information about the llvm-commits mailing list