[PATCH] D59518: [DwarfDebug] Skip entries to big for 16 bit size field in Dwarf < 5.

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.





================
Comment at: llvm/test/MC/X86/dwarf-size-field-overflow.test:48
+    for i in range(0, N):
+        calls.append(CALL.format(i * 128))
+    print(SKELETON.format('\n'.join(calls)))
----------------
If you make this (i * 1000000) you will need about half as many fields, which will make the test run a little faster.
DWARF expressions will encode the constant value in the smallest possible size, regardless of the size of the associated field; so 0 encodes in 1 byte, 512 in 2  bytes, and so on, even for a 64-bit field. That's why larger constant values will mean you need fewer fields.
It's a bit picky, but as it's trivial to make this test run faster (many fewer lines to generate and parse etc) it seems worthwhile.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59518/new/

https://reviews.llvm.org/D59518