[PATCH] D59499: [MIPS] [microMIPS] Enable dynamic stack realignment.

[Simon Atanasyan via Phabricator via llvm-commits]

atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.

LGTM with a few nits

> We simply weaken the condition to not include micromips.

I guess you mean **mips16** not **micromips** in the comment to the patch. Right?

> Should I update the test with the given script?

I would keep this change compact and do not regenerate test cases using the `update_llc_test_checks.py` script.



================
Comment at: lib/Target/Mips/MipsRegisterInfo.cpp:324
 
-  // Support dynamic stack realignment only for targets with standard encoding.
-  if (!Subtarget.hasStandardEncoding())
+  // Support dynamic stack realignment only for targets that are not Mips16.
+  if (Subtarget.inMips16Mode())
----------------
I would write the comment as "Support dynamic stack realignment for all targets except Mips16."


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59499/new/

https://reviews.llvm.org/D59499