[PATCH] D57379: X86AsmParser: Do not process a non-existent token

[Brandon Jones via Phabricator via llvm-commits]

BrandonTJones updated this revision to Diff 191279.
BrandonTJones added a comment.

added test case


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57379/new/

https://reviews.llvm.org/D57379

Files:
  llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
  llvm/test/MC/AsmParser/unfinished-op.s
  llvm/test/MC/X86/x86_operands.s


Index: llvm/test/MC/X86/x86_operands.s
===================================================================
--- llvm/test/MC/X86/x86_operands.s
+++ llvm/test/MC/X86/x86_operands.s
@@ -9,7 +9,7 @@
         addl $a, %eax
 # CHECK: addl $3, %eax
         addl $1 + 2, %eax
-        
+
 # Disambiguation
 
 # CHECK: addl $1, 8
@@ -26,7 +26,7 @@
         addl $1, (%eax)
 # CHECK: addl $1, 8(,%eax)
         addl $1, (4+4)(,%eax)
-        
+
 # Indirect Memory Operands
 # CHECK: addl $1, 1(%eax)
         addl $1, 1(%eax)
Index: llvm/test/MC/AsmParser/unfinished-op.s
===================================================================
--- /dev/null
+++ llvm/test/MC/AsmParser/unfinished-op.s
@@ -0,0 +1,4 @@
+# RUN: not llvm-mc -triple i386-unknown-unknown %s 2>&1 > /dev/null| FileCheck %s --check-prefix=CHECK-ERROR
+
+#CHECK-ERROR: error: instruction must have size higher than 0
+    .byte 64;""
Index: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
===================================================================
--- llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
+++ llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
@@ -2981,6 +2981,11 @@
   case Match_MnemonicFail:
     break;
   }
+  if (Op.getToken().empty()) {
+    Error(IDLoc, "instruction must have size higher than 0", EmptyRange,
+          MatchingInlineAsm);
+    return true;
+  }
 
   // FIXME: Ideally, we would only attempt suffix matches for things which are
   // valid prefixes, and we could just infer the right unambiguous


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57379.191279.patch
Type: text/x-patch
Size: 1498 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190319/7951eb97/attachment.bin>