[PATCH] D58712: Changes for Installing SwiftPM for Apple Swift 5 Toolchain on PowerPC64LE

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 19 06:03:13 PDT 2019


lebedev.ri added inline comments.


================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:12081
 
-  for (int i = 1, e = N->getNumOperands(); i < e; ++i) {
+  for (int i = 1, e = N->getNumOperands(); i < e; i++) {
     // If any inputs are fp_round(extload), they all must be.
----------------
Are you sure this is the right patch?
`i` is int, and this is only changing post-increment into pre-increment.
I really don't see how that could matter here, the return value of that increment operation is not used.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58712/new/

https://reviews.llvm.org/D58712





More information about the llvm-commits mailing list