[PATCH] D59530: [LLD][COFF] Fix /linkrepro with options that take a filename or path

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 19 05:57:31 PDT 2019


aganea added a comment.

In D59530#1434688 <https://reviews.llvm.org/D59530#1434688>, @mstorsjo wrote:

> Aren't all of `/implib`, `/pdb`and `/out` output files? In that sense it doesn't matter where they are written in the repro case (and writing them locally instead of somewhere else with an absolute path probably is more convenient?).


Yes, however our build system generates cmd-lines with full or relative paths for these options, which makes the response unusable (because the paths aren't there on the reproducer's machine)

Are you suggesting that we stripped those options from their path, and only kept the filename? That would be a good alternative.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59530/new/

https://reviews.llvm.org/D59530





More information about the llvm-commits mailing list