[PATCH] D59378: [InstCombine] Prevent icmp transform that can cause inf loop if part of min/max

Mon Mar 18 19:40:11 PDT 2019

tejohnson added a comment.

In D59378#1433795 <https://reviews.llvm.org/D59378#1433795>, @spatel wrote:

> In D59378#1433602 <https://reviews.llvm.org/D59378#1433602>, @nikic wrote:
>
> > @spatel I've created D59506 <https://reviews.llvm.org/D59506> for the InstSimplify change.
>
>
> Thanks! I think we can safely abandon this patch...until we hit the next infinite loop (although that extra regression test in this patch should still be committed).

Thanks. I will commit the extra regression test independently. Before we abandon this, let me make sure the other patch fixes my original infinite loop, which as I mentioned was exposed by the instruction sinking done during InstCombine. I'll take a look when I'm back in the office tomorrow.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59378/new/

https://reviews.llvm.org/D59378