[PATCH] D59419: [XCOFF] Add functionality for parsing AIX XCOFF object files header .

[Sean Fertile via Phabricator via llvm-commits]

sfertile added a comment.

I've added a few reviewers who have committed to the other file formats recently since none of us have  a lot of experience with this part of llvm.



================
Comment at: llvm/include/llvm/Object/XCOFFObjectFile.h:36
+
+struct XCOFFFileHeader {
+  support::ubig16_t Magic;
----------------
Rather then defining these in the `llvm::object` namespace why not drop the `XCOFF` part of the name and make the defintion nested inside `XCOFFObjectFile`?


================
Comment at: llvm/include/llvm/Object/XCOFFObjectFile.h:53
+template <typename T>
+static std::error_code getObject(const T *&Obj, MemoryBufferRef M,
+                                 const void *Ptr,
----------------
The only use of this is in XCOFFObjectFile.cpp,  it should be defined there instead of in the header.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59419/new/

https://reviews.llvm.org/D59419