[PATCH] D59393: [NVPTX] generate correct MMA instruction mnemonics with PTX63+.

Tim Shen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 18 16:54:27 PDT 2019


timshen added inline comments.


================
Comment at: llvm/test/CodeGen/NVPTX/wmma.py:244
+
 main()
----------------
timshen wrote:
> Who is supposed to run this script? Can we check-in the result of this script and make them part of the regression tests?
> 
> Relatedly, for other backends we have a framework for it. See `llvm/utils/update_llc_test_checks.py`. The generated file looks like `llvm/test/CodeGen/PowerPC/atomics-regression.ll`.
> 
> One of the advantages to check-in the generated file is that, and succeeding behavioral changes are reflected in the patch.
> Who is supposed to run this script?

I guess I can answer this part - lit. Still, it'd be great to check-in the generated .ll files with RUN lines in them.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59393/new/

https://reviews.llvm.org/D59393





More information about the llvm-commits mailing list