[PATCH] D59517: AMDGPU: Add support for cross address space synchronization scopes

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUMachineModuleInfo.h:72
+  /// otherwise
+  bool isOneAs(SyncScope::ID SSID) const {
+    return SSID == getSingleThreadOneAsSSID() ||
----------------
Should expand name, "As" is not clear


================
Comment at: lib/Target/AMDGPU/AMDGPUMachineModuleInfo.h:94
+  /// \returns System synchronization scope ID (single address space).
+  SyncScope::ID getSystemOneAsSSID() const {
+    return SystemOneAsSSID;
----------------
Ditto for the rest


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59517/new/

https://reviews.llvm.org/D59517