[PATCH] D54647: [WebAssembly] Initial implementation of -fPIC codegeneration

[Sam Clegg via Phabricator via llvm-commits]

sbc100 marked an inline comment as done.
sbc100 added inline comments.


================
Comment at: llvm/test/CodeGen/WebAssembly/address-offsets.ll:43
 ; CHECK-NEXT: .functype load_test1 (i32) -> (i32){{$}}
-; CHECK-NEXT: i32.const $push0=, 2{{$}}
+; CHECK-NEX T: i32.const $push0=, 2{{$}}
 ; CHECK-NEX T: i32.shl   $push1=, $0, $pop0{{$}}
----------------
aheejin wrote:
> Are these temporarily disabled? (Same for other occurrences below) If so, can we add a comment why? If it's not temporary we can maybe delete them?
These tests we deliberately disabled in https://reviews.llvm.org/D24053.  See the TODO comment above.

Whoever gets around to fixing them will need to make the fast-isel compatible too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54647/new/

https://reviews.llvm.org/D54647