[PATCH] D59506: [ValueTracking][InstSimplify] Support min/max selects in computeConstantRange()

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

If we want to be conservative for compile-time, we could use the simple pattern matchers (m_SMax...) rather than the heavier ValueTracking call. But we don't have that option currently for abs/nabs.
It seems like we've accomplished the improvement for almost no extra cost though, so that's probably a moot point now.



================
Comment at: llvm/test/Transforms/InstSimplify/cmp_of_min_max.ll:4
 
 define i1 @test_umin1(i32 %n) {
 ; CHECK-LABEL: @test_umin1(
----------------
The min and max names for these tests seem inverted (ugt -> umax)?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59506/new/

https://reviews.llvm.org/D59506