[PATCH] D59396: [MsgPack] Attempt to fix failure on windows expensive checks bot

Tim Renouf via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 18 12:00:43 PDT 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rL356394: [MsgPack][AMDGPU] Fix unflushed raw_string_ostream bugs on windows expensive… (authored by tpr, committed by ).

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59396/new/

https://reviews.llvm.org/D59396

Files:
  llvm/trunk/lib/BinaryFormat/MsgPackDocumentYAML.cpp
  llvm/trunk/lib/Target/AMDGPU/SIMachineFunctionInfo.cpp


Index: llvm/trunk/lib/BinaryFormat/MsgPackDocumentYAML.cpp
===================================================================
--- llvm/trunk/lib/BinaryFormat/MsgPackDocumentYAML.cpp
+++ llvm/trunk/lib/BinaryFormat/MsgPackDocumentYAML.cpp
@@ -61,7 +61,7 @@
     llvm_unreachable("not scalar");
     break;
   }
-  return S;
+  return OS.str();
 }
 
 /// Convert the StringRef and use it to set this DocNode (assuming scalar). If
Index: llvm/trunk/lib/Target/AMDGPU/SIMachineFunctionInfo.cpp
===================================================================
--- llvm/trunk/lib/Target/AMDGPU/SIMachineFunctionInfo.cpp
+++ llvm/trunk/lib/Target/AMDGPU/SIMachineFunctionInfo.cpp
@@ -323,8 +323,10 @@
 static yaml::StringValue regToString(unsigned Reg,
                                      const TargetRegisterInfo &TRI) {
   yaml::StringValue Dest;
-  raw_string_ostream OS(Dest.Value);
-  OS << printReg(Reg, &TRI);
+  {
+    raw_string_ostream OS(Dest.Value);
+    OS << printReg(Reg, &TRI);
+  }
   return Dest;
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59396.191138.patch
Type: text/x-patch
Size: 1019 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190318/6edb6cf1/attachment.bin>


More information about the llvm-commits mailing list