[PATCH] D59491: Fix relative thin archive path handling

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 18 10:28:19 PDT 2019


ruiu added inline comments.


================
Comment at: include/llvm/Object/ArchiveWriter.h:39-40
 
-std::string computeArchiveRelativePath(StringRef From, StringRef To);
+std::string computeArchiveRelativePath(StringRef From, StringRef To,
+                                       bool ForceRelative = false);
 
----------------
This function is supposed to compute an archive relative path (as the name says), and it now has ForceRelative flag? That's confusing.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59491/new/

https://reviews.llvm.org/D59491





More information about the llvm-commits mailing list