[PATCH] D59496: [llvm-objcopy] - Fix a st_name of the first symbol table entry.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Perhaps you should add a test for other empty-named symbols?



================
Comment at: test/tools/llvm-objcopy/ELF/symtab-null-entry.test:27
+  # We need to have a symbol, otherwise the original
+  # issue that was fixed did not reproduce.
+    - Name:     foo
----------------
did not reproduce -> is not reproduced by this test.


================
Comment at: tools/llvm-objcopy/ELF/Object.cpp:498
   // size before layout is decided.
+  // Ignore the symbols with empty names, e.g special first symbol entry,
+  // some sections symbols etc.
----------------
e.g special first symbol entry -> e.g. the null symbol entry

for consistency with our wording elsewhere, I believe.


================
Comment at: tools/llvm-objcopy/ELF/Object.cpp:499
+  // Ignore the symbols with empty names, e.g special first symbol entry,
+  // some sections symbols etc.
   for (auto &Sym : Symbols)
----------------
sections -> section


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59496/new/

https://reviews.llvm.org/D59496