[PATCH] D59295: [AMDGPU] Pre-allocate WWM registers to reduce VGPR pressure.

Neil Henning via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 18 08:39:09 PDT 2019


sheredom updated this revision to Diff 191099.
sheredom added a comment.

Reduce the number of DPP calls in the test for cleanliness, and reintroduce the convergent on WWM. The CFG test contains the bug that was exposed by the lack of convergent on WWM, LLVM will **sink** the WWM statement out of the branch which totally messes up all calculations.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59295/new/

https://reviews.llvm.org/D59295

Files:
  include/llvm/IR/IntrinsicsAMDGPU.td
  lib/Target/AMDGPU/AMDGPU.h
  lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
  lib/Target/AMDGPU/CMakeLists.txt
  lib/Target/AMDGPU/SIFixWWMLiveness.cpp
  lib/Target/AMDGPU/SIInstrInfo.cpp
  lib/Target/AMDGPU/SIInstructions.td
  lib/Target/AMDGPU/SIMachineFunctionInfo.h
  lib/Target/AMDGPU/SIPreAllocateWWMRegs.cpp
  lib/Target/AMDGPU/SIRegisterInfo.cpp
  lib/Target/AMDGPU/SIWholeQuadMode.cpp
  test/CodeGen/AMDGPU/atomic_optimizations_buffer.ll
  test/CodeGen/AMDGPU/atomic_optimizations_global_pointer.ll
  test/CodeGen/AMDGPU/atomic_optimizations_local_pointer.ll
  test/CodeGen/AMDGPU/atomic_optimizations_raw_buffer.ll
  test/CodeGen/AMDGPU/atomic_optimizations_struct_buffer.ll
  test/CodeGen/AMDGPU/fix-wwm-liveness.mir
  test/CodeGen/AMDGPU/indirect-addressing-term.ll
  test/CodeGen/AMDGPU/wqm.mir
  test/CodeGen/AMDGPU/wwm-reserved.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59295.191099.patch
Type: text/x-patch
Size: 57395 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190318/09a2d375/attachment.bin>


More information about the llvm-commits mailing list