[PATCH] D59251: [Documentation] Proposal for plan to change variable names

[MyDeveloperDay via Phabricator via llvm-commits]

MyDeveloperDay added inline comments.


================
Comment at: llvm/docs/Proposals/VariableNames.rst:294
+      reformat the affected lines according to the rules in ``.clang-format``.
+
+#. Gather feedback and refine the process as appropriate.
----------------
@michaelplatings I have identifier a number of issues


```
bugs.llvm.org/PR41119  - [clang-tidy] readability-identifier-naming incorrectly fixes lambda capture
bugs.llvm.org/PR41120  - [clang-tidy] readability-identifier-naming incorrectly fixes variables which become keywords
      (previously call out here with regards to Int being renamed to int)
bugs.llvm.org/PR41122 - [clang-tidy] readability-identifier-naming misses fixing member variables in destructor
```

(and there could likely me more)

Which would need to be fixed in clang-tidy prior to any rename activity to prevent this process being painful. I think this is a good dog fooding opportunity for clang-tidy.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59251/new/

https://reviews.llvm.org/D59251