[PATCH] D59351: [llvm-objcopy] Add --update-section

[Eugene Leviant via Phabricator via llvm-commits]

evgeny777 marked an inline comment as done.
evgeny777 added a comment.

> I suspect that this is going to interact nastily with D59843.

Sorry, can't find this patch. What's this?

> Does GNU objcopy support updating sections within segments?

Yep. Here is RFC https://binutils.sourceware.narkive.com/LI0gnMHb/rfc-objcopy-add-update-section-option.



================
Comment at: tools/llvm-objcopy/ObjcopyOpts.td:260
+defm update_section
+    : Eq<"update-section", "Add section <name> with contents from a file <file>.">,
+      MetaVarName<"name=file">;
----------------
jhenderson wrote:
> Add, append to or replace the section contents? Adding doesn't make sense if the switch is called update-section...
s/Add/Update/g


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59351/new/

https://reviews.llvm.org/D59351