[PATCH] D59025: Add --add-ghashes to llvm-objcopy to append a .debug$H to coff objects

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D59025#1428431 <https://reviews.llvm.org/D59025#1428431>, @rupprecht wrote:

> Anyway, I'm not really that opposed to this change, I just want to figure out what's the threshold for adding flags like this. It's probably totally fine, especially as it seems fairly isolated. I added a few other reviewers who might have an idea. I've never heard of ghashes, so I might not be the best person to comment on this change (other than my existing comments).


FWIW, my opinion is that there is nothing wrong with adding new flags that don't otherwise exist in GNU objcopy as long as:

1. They don't have a short alias, or a name that is likely to clash with a new switch in GNU objcopy in the future.
2. There's a real-world use-case (which could be as simple as significantly simplifying our own testing or whatever).
3. The change isn't too invasive, or if it is, there's a massive use-case to make the trade-off worthwhile.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59025/new/

https://reviews.llvm.org/D59025