[PATCH] D59488: [llvm-objcopy] - Calculate the string table section sizes correctly.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 18 06:23:45 PDT 2019


grimar created this revision.
grimar added reviewers: jakehehrlich, jhenderson, alexshap, rupprecht.
Herald added subscribers: MaskRay, arichardson, emaste.
Herald added a reviewer: espindola.

This fixes the https://bugs.llvm.org/show_bug.cgi?id=40980.

Previously if string optimization occurred as a result of
StringTableBuilder's `finalize()` method, the size wasn't updated.

This hopefully also makes the interaction between sections during finalization
processes a bit more clear.


https://reviews.llvm.org/D59488

Files:
  test/tools/llvm-objcopy/ELF/basic-archive-copy.test
  test/tools/llvm-objcopy/ELF/cross-arch-sections-symbols.test
  test/tools/llvm-objcopy/ELF/shstrtab-optimize.test
  test/tools/llvm-objcopy/ELF/strtab-optimize.test
  tools/llvm-objcopy/ELF/Object.cpp
  tools/llvm-objcopy/ELF/Object.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59488.191072.patch
Type: text/x-patch
Size: 4982 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190318/f4e96201/attachment.bin>


More information about the llvm-commits mailing list