[PATCH] D59363: [SelectionDAG] Add icmp UNDEF handling to SelectionDAG::FoldSetCC

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 17 15:06:13 PDT 2019


RKSimon added a comment.

In D59363#1432683 <https://reviews.llvm.org/D59363#1432683>, @uweigand wrote:

> In D59363#1431933 <https://reviews.llvm.org/D59363#1431933>, @jonpa wrote:
>
> > I think the SystemZ test changes look ok (by replacing the undef operands with an argument the tests are more or less unaffected by this patch), but as usual I will let Uli do the formal approval.
>
>
> The SystemZ test changes LGTM.  It's probably better anyway to have real arguments instead of undefs ...


Thanks @uweigand - once this patch goes in bugpoint should be less likely to reduce icmp arguments.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59363/new/

https://reviews.llvm.org/D59363





More information about the llvm-commits mailing list