[PATCH] D59450: [ValueTracking] Use ConstantRange overflow check for signed add (NFC)
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Mar 17 13:54:10 PDT 2019
lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.
Looks good as a NFC to me.
================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4132
+ mapOverflowResult(LHSRange.signedAddMayOverflow(RHSRange));
+ if (OR != OverflowResult::MayOverflow)
+ return OR;
----------------
I'm guessing `OverflowResult` won't grow, so there is no danger of accidentally doing the wrong thing here.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59450/new/
https://reviews.llvm.org/D59450
More information about the llvm-commits
mailing list