[PATCH] D59450: [ValueTracking] Use ConstantRange overflow check for signed add (NFC)
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Mar 17 13:39:29 PDT 2019
lebedev.ri added a comment.
Almost there ...
================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4151
(AddKnown.isNegative() && LHSOrRHSKnownNegative)) {
return OverflowResult::NeverOverflows;
}
----------------
This is still reachable, `computeKnownBits(Add, ...` is still more powerful than `signedAddMayOverflow()`?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59450/new/
https://reviews.llvm.org/D59450
More information about the llvm-commits
mailing list