[PATCH] D59472: [InstCombine] Add tests for add nuw + uaddo

Dan Robertson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 17 12:21:40 PDT 2019


dlrobertson marked an inline comment as done.
dlrobertson added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/uadd-with-overflow.ll:54
+
+define { <2 x i32>, <2 x i1> } @no_fold_splat_undef_constant(<2 x i32> %x) {
+; CHECK-LABEL: @no_fold_splat_undef_constant(
----------------
lebedev.ri wrote:
> You could also add variations with non-splat non-undef constants
I'm not sure I follow. Wouldn't a non-splat non-undef variation of this test be something like `simple_fold` on line 10?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59472/new/

https://reviews.llvm.org/D59472





More information about the llvm-commits mailing list