[PATCH] D59333: ELF: Rename Configuration::Static to Bstatic. NFCI.

Sun Mar 17 07:34:08 PDT 2019

grimar added a comment.

In D59333#1428331 <https://reviews.llvm.org/D59333#1428331>, @ruiu wrote:

> Maybe we should also update the helptext of Bstatic? It currently says that "Do not link against shared libraries" which doesn't sound like it captures the exact meaning of the option.

"Do not search for dynamic libraries when linking"?

================
Comment at: lld/ELF/Driver.cpp:227
+    if (Config->Bstatic || Config->Relocatable) {
       error("attempted static link of dynamic object " + Path);
       return;
----------------
Not sure if we might want to improve the error reporting here later too.
I guess it would not be clear to understand what is wrong in case of this error.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59333/new/

https://reviews.llvm.org/D59333