[PATCH] D59462: [WebAssembly] Optimize the number of routing blocks in FixIrreducibleCFG
Bruno Ricci via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Mar 16 11:34:01 PDT 2019
riccibruno added inline comments.
================
Comment at: lib/Target/WebAssembly/WebAssemblyFixIrreducibleControlFlow.cpp:406
+ // <<Predecessor is within the loop?, loop entry>, routing block>
+ std::map<std::pair<bool, MachineBasicBlock *>, MachineBasicBlock *> Map;
+ for (auto *Pred : AllPreds) {
----------------
aheejin wrote:
> This was previously `DenseMap`, but I changed this to `std::map` because to use `std::pair` as a key to `DenseMap` I need to write `DenseMapInfo` routines and I don't think it's really worth it because this map will be quite small anyway.
Note that `DenseMapInfo` is already implemented for `std::pair`
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59462/new/
https://reviews.llvm.org/D59462
More information about the llvm-commits
mailing list