[PATCH] D59335: [RFC] Enable vectorization on Neon even without fast-math

Sat Mar 16 05:36:23 PDT 2019

rengolin added a comment.

In D59335#1428404 <https://reviews.llvm.org/D59335#1428404>, @sanjoy wrote:

> > langref part seems to be missing.
>
> I'll add it if/once reviewers are okay with this approach.

Actually, adding the langref changes to the patch help reviewers understand the new semantics and provide an atomic change, guaranteeing that, if the patch is reverted, so are the docs.

>> That recently happened with sanitizer, and backend (predicates? don't recall),
> 
> By "That" you mean they too ran out of bits?  In this specific case we're running out of bits in `Value::SubclassOptionalData`, I don't see a simple fix for it that doesn't involve increasing the size of `llvm::Value`.  I could steal a bit or two from, say, the `UseList` pointer but I'm not sure that counts as simple.

(not for this patch, but) Could you factor the flags out completely? It would replace space for computation, and probably need a new handler class, but it would be cleaner than having some flags in and others out.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59335/new/

https://reviews.llvm.org/D59335