[PATCH] D59445: Restore comment regarding why Reloc::PIC_ can't be PIC

[Sam Clegg via Phabricator via llvm-commits]

sbc100 created this revision.
Herald added subscribers: llvm-commits, aheejin.
Herald added a project: LLVM.

The original change back in rL29307 <https://reviews.llvm.org/rL29307> explained this but it was
lost somewhere along the way.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D59445

Files:
  llvm/include/llvm/Support/CodeGen.h


Index: llvm/include/llvm/Support/CodeGen.h
===================================================================
--- llvm/include/llvm/Support/CodeGen.h
+++ llvm/include/llvm/Support/CodeGen.h
@@ -18,13 +18,14 @@
 
   // Relocation model types.
   namespace Reloc {
-  enum Model { Static, PIC_, DynamicNoPIC, ROPI, RWPI, ROPI_RWPI };
+    // Cannot be named PIC due to collision with -DPIC
+    enum Model { Static, PIC_, DynamicNoPIC, ROPI, RWPI, ROPI_RWPI };
   }
 
   // Code model types.
   namespace CodeModel {
     // Sync changes with CodeGenCWrappers.h.
-  enum Model { Tiny, Small, Kernel, Medium, Large };
+    enum Model { Tiny, Small, Kernel, Medium, Large };
   }
 
   namespace PICLevel {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59445.190939.patch
Type: text/x-patch
Size: 703 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190316/9a70a33c/attachment.bin>