[PATCH] D54647: [WebAssembly] Initial implementation of -fPIC codegeneration

[Sam Clegg via Phabricator via llvm-commits]

sbc100 marked an inline comment as done.
sbc100 added inline comments.


================
Comment at: llvm/include/llvm/MC/MCSymbolWasm.h:21
   bool IsComdat = false;
+  mutable bool IsUsedInGOT = false;
   Optional<std::string> ImportModule;
----------------
dschuff wrote:
> {meme, src=ohno, below=mutable}
> 
> sad how often `mutable` is used in LLVM. I guess maybe it means we're too aggressive about `const` overall?
I only dun it cos they already dun it before guvnor:  https://github.com/llvm-mirror/llvm/blob/7feefc2fe73c27062407322a14241d1a4497cdb1/include/llvm/MC/MCSymbol.h#L106

TBH I didn't even know about this keyword!  And its seems crazy but it seems like that is the solution in this case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54647/new/

https://reviews.llvm.org/D54647