[PATCH] D59275: [ELF] Emit weak-undef symbols in .dynsym of a PIE only if linked against shared libs.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lld/ELF/Symbols.cpp:271
+  // If a PIE binary was not linked against any shared libraries, then we can
+  // safely drop adding weak undef symbols to .dynsym.
+  if (isUndefWeak() && Config->Pie && SharedFiles.empty())
----------------
safely drop weak undef symbols from .dynsym?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59275/new/

https://reviews.llvm.org/D59275